Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt pooch #205

Open
bjlittle opened this issue Oct 23, 2023 · 1 comment
Open

Adopt pooch #205

bjlittle opened this issue Oct 23, 2023 · 1 comment

Comments

@bjlittle
Copy link
Contributor

Would we be willing to adopt pooch as a more robust way to download remote assets?

If there's enough interest for this, then I'm happy to investigate further and see whether pooch can easily be integrated into the existing framework.

@bjlittle
Copy link
Contributor Author

bjlittle commented Oct 23, 2023

The main advantages, as I see them, from adopting pooch are:

  • timeout and retry management through pooch
  • validation of download payload (through payload sha's)
  • compression/decompression support of assets (although probably not much gain from compressing pngs)
  • pooch won't re-download an existing assets i.e., provides cache support
  • we drop our bespoke code to do this

There may be more ... but I'd be interested to know whether you already know this isn't a good fit for pytest-mpl and has been rejected as an option, or whether there's a blocker/disadvantage that I'm not aware of ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant