Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramater remove_text in mpl_image_compare decorator does not remove axis labels #120

Open
RNKuhns opened this issue May 16, 2021 · 0 comments

Comments

@RNKuhns
Copy link

RNKuhns commented May 16, 2021

When choosing remove_text=True I would have assumed that the text for axis labels was removed along with the axis ticks and any titles. But it doesn't seem to do that.

The code uses remove_ticks_and_titles from matplotlib and that does not appear to remove the axis labels (See matplotlib documentation).

I'd propose updating the remove_text conditional as follows:

if remove_text:
    remove_ticks_and_titles(fig)
    for ax in fig.get_axes():
        ax.set_xlabel = ""
        ax.set_ylabel = ""

If this seems reasonable, I can submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant