Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus typedef for Typescript #74

Open
eddieajau opened this issue Sep 13, 2016 · 9 comments
Open

ServiceBus typedef for Typescript #74

eddieajau opened this issue Sep 13, 2016 · 9 comments

Comments

@eddieajau
Copy link

Hi Matt. I've published a typedef for the ServiceBus here it's still pretty rough and I need to add more DocBlocks, but is this something you are interested in linking to?

@mateodelnorte
Copy link
Owner

I'm not against it. How will these be used, in conjunction with servicebus?

As an aside, I'd prefer the package name was changed from mumba-typedef-servicebus to servicebus-typedef, as that sounds a bit more straightforward and seems to connote it's a package for typedefs pertaining to servicebus.

@eddieajau
Copy link
Author

How will these be used, in conjunction with servicebus?

It's only used if you are including servicebus is a Typescript project.

Regarding package name, that's our standard naming convention for anything I produce at work and if you did do a link-out, I'd qualify that it's third-party supported. However, I'd be more than happy to relocate and maintain it under something like mateodelnorte/servicebus-typedef which gives you full control over the naming convention :) I'm happy either way.

@mateodelnorte
Copy link
Owner

Other than

$ npm install --save mumba-typedef-servicebus
$ typings install servicebus=npm:mumba-typedef-servicebus --save --global

What needs to be done to use the projects together?

@eddieajau
Copy link
Author

That's it. You can then just use an import like:

import {Bus} from 'servicebus';

and Typescript can do all it's compile-time checks and balances.

@drew-r
Copy link

drew-r commented Oct 13, 2016

Type defs can now be installed via npm, how about a @types/servicebus package?

@mateodelnorte
Copy link
Owner

I'm all for whatever is easiest and most obvious to users.

@obiwan007
Copy link

Any news regarding the @types/servicebus?

@mateodelnorte
Copy link
Owner

What's the question?

@obiwan007
Copy link

Sorry about the @types package. Another option would be to just put the d.ts file into the default package. Makes it easier to keep it in sync...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants