Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass alternateExchange config to assertExchange() and bindQueue() #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

badavis
Copy link

@badavis badavis commented Jul 6, 2018

will close #115

@patrickleet
Copy link
Collaborator

@badavis hey - sorry but this has gotten stale - also we set up semantic-release which relies on formatting commit messages properly.

Any chance you could open a new PR without the change to publishConfig and also in the format

feat: message

you can run use npm run commit instead of git commit to use a wizard to ensure it is formatted correctly.

This way it will trigger the appropriate version bump.

Sorry for the inconvenience!

Copy link
Collaborator

@patrickleet patrickleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this plus commit message format

@@ -47,5 +47,8 @@
"commitizen": {
"path": "./node_modules/cz-conventional-changelog"
}
},
"publishConfig": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this in new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of alternate exchanges
2 participants