Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterController uses :wait for starting, but not stopping (or restarting) #310

Closed
emschwar opened this issue May 13, 2016 · 1 comment · May be fixed by #311
Closed

ClusterController uses :wait for starting, but not stopping (or restarting) #310

emschwar opened this issue May 13, 2016 · 1 comment · May be fixed by #311

Comments

@emschwar
Copy link

We used to do this in 1.6.3 for a cluster of thin servers:

bundle exec thin --timeout 5 -C adapters/web_server/config/production_thin.yml restart

This was fine, because the --timeout wasn't passed into the server. It looks like that in 1.6.4, the servers started taking timeout configurations, so as of that version our command-line script wasn't just timing out the restart, it was setting a timeout config for the servers it restarted as well.

So we changed it to

bundle exec thin --wait 5 -C adapters/web_server/config/production_thin.yml restart

But this doesn't do what we want either; the --wait is filtered out of the start & stop jobs created by Thin::Controllers::Cluster using Thin::Command. I had started to work on a PR to pass --wait through from the cluster controller, but since it appears that it was omitted on purpose, I figured I'd file this issue to see if there was a better way, or if --wait was omitted because it was a problem.

@emschwar
Copy link
Author

Is there something I can do to help move this along? Any changes you'd like to the accompanying PR?

@ioquatix ioquatix closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants