Compilation error related SPI although parallel interface is used.

[pewa88]

Hello,

I am trying to get a display with a HX8357D into operation using ESP IDF ,LovyanGFX and 8-bit parallel interface.
The target has been configured using idf.py set-target esp32s3. LovyanGFX release version 1.1.12 is fetched using the IDF component manager. My configuration looks like this:

// Create a class derived from LGFX_Device for your own configuration.
class EA_TFT035 : public lgfx::LGFX_Device
{
    /* The class name may be changed from "LGFX" to another name.
    * When used with AUTODETECT, "LGFX" is already in use, so change the name to something other than LGFX.
    * If multiple panels are used at the same time, give each a different name.
    * If the class name is changed, the constructor name must also be changed to the same name.*/

    // Prepare an instance that matches the type of panel to be connected.
    lgfx::Panel_HX8357D     _panel_instance;


    // Prepare an instance for the type of bus to which the panel is connected.
    lgfx::Bus_Parallel8 _bus_instance;   // 8ビットパラレルバスのインスタンス (ESP32のみ)

    // Provide an instance if backlight control is available. (Delete if not needed)
    lgfx::Light_PWM     _light_instance;

    public:
        // Create a constructor and configure various settings here.
        // If you change the class name, specify the same name for the constructor.
        EA_TFT035(void)
        {
            { 
                // Configure bus control settings.
                auto cfg = _bus_instance.config();    // バス設定用の構造体を取得します。

                // 8-bit parallel bus configuration
                cfg.i2s_port = I2S_NUM_0;     // 使用するI2Sポートを選択 (I2S_NUM_0 or I2S_NUM_1) (ESP32のI2S LCDモードを使用します)
                cfg.freq_write = 20000000;    // 送信クロック (最大20MHz, 80MHzを整数で割った値に丸められます)
                cfg.pin_wr = 36;              // WR を接続しているピン番号
                cfg.pin_rd = 35;              // RD を接続しているピン番号
                cfg.pin_rs = 15;              // RS(D/C)を接続しているピン番号
                cfg.pin_d0 =  4;              // D0を接続しているピン番号
                cfg.pin_d1 = 41;              // D1を接続しているピン番号
                cfg.pin_d2 =  5;              // D2を接続しているピン番号
                cfg.pin_d3 = 40;              // D3を接続しているピン番号
                cfg.pin_d4 =  6;              // D4を接続しているピン番号
                cfg.pin_d5 = 39;              // D5を接続しているピン番号
                cfg.pin_d6 =  7;              // D6を接続しているピン番号
                cfg.pin_d7 = 38;              // D7を接続しているピン番号

                _bus_instance.config(cfg);    // Reflect the set value to the bus.
                _panel_instance.setBus(&_bus_instance);      // Set the bus on the panel.
            }

            { // Display panel control settings.
                auto cfg = _panel_instance.config();    // Gets the structure for display panel settings.

                cfg.pin_cs           =    37;  // Pin number to which CS is connected (-1 = disable)
                cfg.pin_rst          =    16;  // Pin number to which RST is connected (-1 = disable)
                cfg.pin_busy         =    -1;  // Pin number to which BUSY is connected (-1 = disable)

                // The following settings have general default values for each panel, so if you are unsure about an item, comment it out and give it a try.

                cfg.panel_width      =   320;  // 実際に表示可能な幅
                cfg.panel_height     =   480;  // 実際に表示可能な高さ
                cfg.offset_x         =     0;  // パネルのX方向オフセット量
                cfg.offset_y         =     0;  // パネルのY方向オフセット量
                cfg.offset_rotation  =     1;  // 回転方向の値のオフセット 0~7 (4~7は上下反転)
                cfg.dummy_read_pixel =     8;  // ピクセル読出し前のダミーリードのビット数
                cfg.dummy_read_bits  =     1;  // ピクセル以外のデータ読出し前のダミーリードのビット数
                cfg.readable         =  true;  // データ読出しが可能な場合 trueに設定
                cfg.invert           = false;  // パネルの明暗が反転してしまう場合 trueに設定
                cfg.rgb_order        = false;  // パネルの赤と青が入れ替わってしまう場合 trueに設定
                cfg.dlen_16bit       = false;  // 16bitパラレルやSPIでデータ長を16bit単位で送信するパネルの場合 trueに設定
                cfg.bus_shared       = false;  // SDカードとバスを共有している場合 trueに設定(drawJpgFile等でバス制御を行います)

                // The following should be set only when the display is shifted by drivers with variable number of pixels, such as ST7735 and ILI9163.
                //    cfg.memory_width     =   240;  // ドライバICがサポートしている最大の幅
                //    cfg.memory_height    =   320;  // ドライバICがサポートしている最大の高さ

                _panel_instance.config(cfg);
            }

            { // Configure the backlight control settings. (Delete if not needed)
                auto cfg = _light_instance.config();    // バックライト設定用の構造体を取得します。

                cfg.pin_bl = 1;              // Pin number to which the backlight is connected
                cfg.invert = false;           // バックライトの輝度を反転させる場合 true
                cfg.freq   = 44100;           // Diming frequency (DIO5661: 200Hz - 200kHz)
                cfg.pwm_channel = 7;          // 使用するPWMのチャンネル番号

                _light_instance.config(cfg);
                _panel_instance.setLight(&_light_instance);  // Set the backlight on the panel.
            }

            setPanel(&_panel_instance); // Set the panel to be used.
        }
};

// Create an instance of the prepared class.
EA_TFT035 display;

/*Change to your screen resolution*/
static const uint16_t screenWidth  = 480;
static const uint16_t screenHeight = 320;

static lv_disp_draw_buf_t draw_buf;
static lv_color_t buf[ screenWidth * screenHeight / 10 ];

/* Display flushing */
void my_disp_flush( lv_disp_drv_t *disp_drv, const lv_area_t *area, lv_color_t *color_p )
{
    uint32_t w = ( area->x2 - area->x1 + 1 );
    uint32_t h = ( area->y2 - area->y1 + 1 );

    display.startWrite();
    display.setAddrWindow( area->x1, area->y1, w, h );
    tft.writePixels((lgfx::rgb565_t *)&color_p->full, w * h);
    tft.endWrite();

    lv_disp_flush_ready( disp_drv );
}

void Display_SetupGFX(void)
{
#if 1
    // SPI bus and panel initialization to be performed and available
    display.init();
    display.setRotation(1); /* Landscape orientation */
    display.setBrightness(50U);

    lv_init();
    lv_disp_draw_buf_init( &draw_buf, buf, NULL, screenWidth * screenHeight / 10 );

    /*Initialize the display*/
    static lv_disp_drv_t disp_drv;
    lv_disp_drv_init( &disp_drv );
    /*Change the following line to your display resolution*/
    disp_drv.hor_res = screenWidth;
    disp_drv.ver_res = screenHeight;
    disp_drv.flush_cb = my_disp_flush;
    disp_drv.draw_buf = &draw_buf;
    lv_disp_drv_register( &disp_drv );
    
    lv_demo_benchmark();

#endif

}

/* ***************************************************************************
 * Tasks
 * ***************************************************************************/
/**
 * @brief Display Task Entry
 *
 * @param pvParameters argument
 */
void Display_Task(void *pvParameters)
{
    uint32_t delayMs;
    TickType_t xDelay;

    while (1)
    {
        delayMs = lv_timer_handler(); /* let the GUI do its work */
        xDelay = delayMs / portTICK_PERIOD_MS;
        vTaskDelay(xDelay);
    }
}

My problem is, I get the a compilation error in LovyanGFX:

.../LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp: In member function 'virtual void lgfx::v1::Bus_SPI::endRead()':
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp:827:5: error: array subscript 0 is outside array bounds of 'volatile uint32_t [0]' [-Werror=array-bounds=]
  827 |     *reg(SPI_PIN_REG(_spi_port)) = pin;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: note: source object is likely at address zero

I get this error in lines 215, 816 and 827 of Bus_SPI.cpp. Why or what for does LovyanGFX need SPI? Did I miss to configure something? Is esp32 used instead of esp32s3 (there is also a folder LovyanGFX/src/lgfx/v1/platforms/esp32s3) or what I am doing wrong?
Not sure if this is a configuration topic, but to me it seems like it. Sorry if this is the wrong section for this question

Any help would be much appreciated.

Best regards,
Peter

[tobozo]

hi,

please specify your version of esp-idf, only a few are supported

* When used with AUTODETECT, "LGFX" is already in use, so change the name to something other than LGFX.

unless you have multiple displays, you should disable autodetect as will use SPI for detection

[pewa88]

Hello,

thanks for the quick reply.

I have only one display and I am not using AUTODETECT.
However, as it seems I am using IDF version ESP-IDF v5.3-dev-2815-gbe06a6f5ff (output from idf.py --version).
Since this is not supported I will try to switch to 5.2.1 and try again. Thanks for the hint.

Another thing I noticed is that to me it seems that HX8357 is not supported by v1.
HX8357 should be supported by v0, but v0 doesn't support esp32s3, only esp32. Is this correct?

Best regards,
Peter

[tobozo]

Panel_HX8357B and Panel_HX8357D are now variants of ILI948x in v1

[pewa88]

Ok, thats great to hear. Thanks for clarification.

Will let you know what happens after I downgraded ESP IDF to v5.2.1 (still in progress)

Best regards,
Peter

[pewa88]

So I finally managed to get ESP IDF 5.2.1 running. There are diferent error and also warnings now, coming from LovyanGFX:

In file included from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:41:
/home/pewa88/esp/esp-idf-v5.2.1/components/soc/esp32s3/include/soc/apb_ctrl_reg.h:9:2: warning: #warning "apb_ctrl_reg is deprecated due to duplicated with syscon_reg, please use syscon_reg instead, they are same" [-Wcpp]
    9 | #warning "apb_ctrl_reg is deprecated due to duplicated with syscon_reg, please use syscon_reg instead, they are same"
      |  ^~~~~~~
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:114: warning: "SOC_GDMA_PAIRS_PER_GROUP_MAX" redefined
  114 |  #define SOC_GDMA_PAIRS_PER_GROUP_MAX SOC_GDMA_PAIRS_PER_GROUP
      | 
In file included from /home/pewa88/esp/esp-idf-v5.2.1/components/esp_hw_support/include/esp_cpu.h:13,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/esp_hw_support/include/spinlock.h:11,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/portable/xtensa/include/freertos/portmacro.h:49,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/portable.h:57,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:69,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.hpp:26,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:21:
/home/pewa88/esp/esp-idf-v5.2.1/components/soc/esp32s3/include/soc/soc_caps.h:160: note: this is the location of the previous definition
  160 | #define SOC_GDMA_PAIRS_PER_GROUP_MAX   5 // when there're multiple GDMA instances, this macro represents the maximum number of GDMA pairs in the same group.
      | 
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp: In function 'cpp::bitwizeshift::result<void, lgfx::v1::error_t> lgfx::v1::spi::init(int, int, int, int, int)':
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:493:29: error: 'INTR_CPU_ID_AUTO' was not declared in this scope
  493 |         buscfg.isr_cpu_id = INTR_CPU_ID_AUTO;
      |                             ^~~~~~~~~~~~~~~~
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp: In function 'void lgfx::v1::i2c::i2c_set_cmd(i2c_dev_t*, uint8_t, uint8_t, uint8_t, bool)':
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:837:14: error: 'struct i2c_dev_t' has no member named 'comd0'; did you mean 'comd'?
  837 |       (&dev->comd0)[index].val = cmd_val;
      |              ^~~~~
      |              comd
[1012/1404] Building CXX object esp-idf/LovyanGFX/CMakeFiles/__idf_LovyanGFX.dir/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp.obj
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp:26: warning: "REG_SPI_BASE" redefined
   26 |   #define REG_SPI_BASE(i)   (DR_REG_SPI1_BASE + (((i)>1) ? (((i)* 0x1000) + 0x20000) : (((~(i)) & 1)* 0x1000 )))
      | 
In file included from /home/pewa88/esp/esp-idf-v5.2.1/components/esp_hw_support/include/esp_memory_utils.h:12,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/portable/xtensa/include/freertos/portmacro.h:54,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/portable.h:57,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:69,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/driver/include/esp_private/spi_common_internal.h:13,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.hpp:36,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp:21:
/home/pewa88/esp/esp-idf-v5.2.1/components/soc/esp32s3/include/soc/soc.h:37: note: this is the location of the previous definition
   37 | #define REG_SPI_BASE(i)         (((i)>=2) ? (DR_REG_SPI2_BASE + (i-2) * 0x1000) : (0))    // GPSPI2 and GPSPI3
      | 
[1013/1404] Building CXX object esp-idf/LovyanGFX/CMakeFiles/__idf_LovyanGFX.dir/src/lgfx/v1/platforms/esp32s3/Bus_Parallel16.cpp.obj
ninja: build stopped: subcommand failed.
ninja failed with exit code 1, output of the command is in the /home/pewa88/projects/esp32/v5.1.2/rpm_meas/build/log/idf_py_stderr_output_5663 and /home/pewa88/projects/esp32/v5.1.2/rpm_meas/build/log/idf_py_stdout_output_5663

I also have no touch, hence no I2C, so I think there must be something wrong with my configuration?

[tobozo]

error: 'struct i2c_dev_t' has no member named 'comd0'; did you mean 'comd'?

can you try to checkout the develop branch of LovyanGFX instead of using the latest relase?

[pewa88]

Sure. I changed to the development branch (git #a0e0d14). I am now able to build, which is already a huge improvement. Thank you very much, I wouldn't have managed to come this far without your help.

There are still some warnings though because of duplicated and deprecated macros:

[1011/1404] Building CXX object esp-idf/LovyanGFX/CMakeFiles/__idf_LovyanGFX.dir/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp.obj
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp:26: warning: "REG_SPI_BASE" redefined
   26 |   #define REG_SPI_BASE(i)   (DR_REG_SPI1_BASE + (((i)>1) ? (((i)* 0x1000) + 0x20000) : (((~(i)) & 1)* 0x1000 )))
      | 
In file included from /home/pewa88/esp/esp-idf-v5.2.1/components/esp_hw_support/include/esp_memory_utils.h:12,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/portable/xtensa/include/freertos/portmacro.h:54,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/portable.h:57,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:69,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/driver/include/esp_private/spi_common_internal.h:13,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.hpp:36,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/Bus_SPI.cpp:21:
/home/pewa88/esp/esp-idf-v5.2.1/components/soc/esp32s3/include/soc/soc.h:37: note: this is the location of the previous definition
   37 | #define REG_SPI_BASE(i)         (((i)>=2) ? (DR_REG_SPI2_BASE + (i-2) * 0x1000) : (0))    // GPSPI2 and GPSPI3
      | 
[1012/1404] Building CXX object esp-idf/LovyanGFX/CMakeFiles/__idf_LovyanGFX.dir/src/lgfx/v1/platforms/esp32/common.cpp.obj
In file included from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:41:
/home/pewa88/esp/esp-idf-v5.2.1/components/soc/esp32s3/include/soc/apb_ctrl_reg.h:9:2: warning: #warning "apb_ctrl_reg is deprecated due to duplicated with syscon_reg, please use syscon_reg instead, they are same" [-Wcpp]
    9 | #warning "apb_ctrl_reg is deprecated due to duplicated with syscon_reg, please use syscon_reg instead, they are same"
      |  ^~~~~~~
/home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:114: warning: "SOC_GDMA_PAIRS_PER_GROUP_MAX" redefined
  114 |  #define SOC_GDMA_PAIRS_PER_GROUP_MAX SOC_GDMA_PAIRS_PER_GROUP
      | 
In file included from /home/pewa88/esp/esp-idf-v5.2.1/components/esp_hw_support/include/esp_cpu.h:13,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/esp_hw_support/include/spinlock.h:11,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/portable/xtensa/include/freertos/portmacro.h:49,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/portable.h:57,
                 from /home/pewa88/esp/esp-idf-v5.2.1/components/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:69,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.hpp:26,
                 from /home/pewa88/projects/esp32/v5.1.2/rpm_meas/managed_components/LovyanGFX/src/lgfx/v1/platforms/esp32/common.cpp:21:
/home/pewa88/esp/esp-idf-v5.2.1/components/soc/esp32s3/include/soc/soc_caps.h:160: note: this is the location of the previous definition
  160 | #define SOC_GDMA_PAIRS_PER_GROUP_MAX   5 // when there're multiple GDMA instances, this macro represents the maximum number of GDMA pairs in the same group.

Best regards,
Peter