Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Pekko support #258

Closed
pjfanning opened this issue Feb 20, 2023 · 10 comments
Closed

Apache Pekko support #258

pjfanning opened this issue Feb 20, 2023 · 10 comments
Assignees

Comments

@pjfanning
Copy link
Contributor

Thanks for maintaining this lib.

Is there any chance that you would consider producing a pekko version? Apache Pekko is still under development but there are usable snapshots at https://repository.apache.org/content/groups/snapshots/org/apache/pekko/

@lomigmegard
Copy link
Owner

Hi, I am indeed following the Pekko project closely. I was waiting for a bit more appetite and stability.

I am also pondering if I should continue supporting both or just migrate it all to pekko (apache-pekko-cors) 🤔

I am busy for the next two weeks, but I will think about it and publish some kind of solution in the horizon of 3-4 weeks. Let me know if there is a more urgent need to remove some blocker for the Pekko project.

@pjfanning
Copy link
Contributor Author

Thanks @lomigmegard - no urgency on this. I'm just asking, generally, if you are interested in maintaining a pekko equivalent of this lib.

@lomigmegard
Copy link
Owner

@pjfanning I am yes, but as you can see there isn't that much code neither. We could also evaluate moving it under the Apache umbrella project.

Over the years the main discussions around this library were all related to which default configuration should be used, as it has impact on security when they are not well-understood.

@lomigmegard lomigmegard changed the title pekko support? Apache Pekko support Feb 20, 2023
@pjfanning
Copy link
Contributor Author

I'm involved with the Apache Pekko work. I'm a bit wary about taking on more libraries right now. The main reasoning behind the current set of repos that we're migrating is because of the license issue caused by the Lightbend move to a Business Software License. With the number of active contributors, we have our hands full with the existing set of repos.

We'll need to consider the implications where Akka ecosystem lib maintainers are not in a position to produce Pekko variants but we are a distance away from that yet.

Regarding akka-http-cors, I did a quick check and it looks Pekko can be supported fairly readily. I tested using pjfanning@2f68c88

@lomigmegard
Copy link
Owner

That's very understandable. I will publish a version for Pekko in the coming weeks then.

Yes I simple find&replace should work, I will see if I create a new repo or keep this one to publish both artifacts.

@mdedetrich
Copy link

I think there is merit in putting this project under the Apache Pekko umbrella but as @pjfanning noted, we have our hands kind of full right now dealing with all of the code/license/package/legal changes necessary for ASF inclusion.

@lomigmegard
Copy link
Owner

Hey @pjfanning, I created pekko-http-cors as a fork of this repo.

Please try to use the first 0.0.0-SNAPSHOT version that I just published, based on the latest Pekko build from March 4th. The repository is https://oss.sonatype.org/content/repositories/snapshots/ch/megard/

@pjfanning
Copy link
Contributor Author

Thanks @lomigmegard - I updated https://github.com/pjfanning/swagger-pekko-http-sample to use your snapshot and it works great. We'll update pekko-grpc in coming days to use pekko-http-cors as well.

@lomigmegard
Copy link
Owner

Great! I will close this issue then. Let's use the new repo for the upcoming coordination or issues, if any.

@mdedetrich
Copy link

PR for pekko-grpc is already up at apache/pekko-grpc#45, thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants