Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review FilteredTree and FilteredComboTree in org.locationtech.udig.style.sld #630

Open
fgdrf opened this issue Nov 29, 2021 · 0 comments
Open

Comments

@fgdrf
Copy link
Contributor

fgdrf commented Nov 29, 2021

While reviewed #617 I stumbled about org.locationtech.udig.style.sld.editor.internal.FilteredTree and subclass org.locationtech.udig.style.sld.editor.internal.FilteredComboTree. Both having Eclipse file comments and seems to be copied from Eclipse.

Questions:

  • Where are the differences to the origin files?
  • Is the implementation of the current used Eclipse Framework better than the one we copied 12 years ago?

Intention: use Eclipse implementation if possible and remove copies from code-base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant