Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WKTWriter empty point/geometrycollection WKT serialization #162

Open
abrokenjester opened this issue Aug 7, 2018 · 1 comment
Open

WKTWriter empty point/geometrycollection WKT serialization #162

abrokenjester opened this issue Aug 7, 2018 · 1 comment
Labels
bug enhancement

Comments

@abrokenjester
Copy link
Contributor

When putting an empty Point through WKTWriter.toString, it produces a string of the form POINT () or POINT(NaN, NaN) instead of POINT EMPTY. Similarly for an empty ShapeCollection, we get the serialization GEOMETRYCOLLECTION () instead of GEOMETRYCOLLECTION EMPTY.
@abrokenjester abrokenjester mentioned this issue Aug 7, 2018
Merged
@dsmiley dsmiley added the bug label Mar 8, 2020
@dsmiley
Copy link
Contributor

dsmiley commented Mar 8, 2020

Thanks for reporting. PRs welcome. Should be easy.

abrokenjester added a commit to abrokenjester/spatial4j that referenced this issue Mar 9, 2020
@abrokenjester
locationtechGH-162 handle empty point / shape collection in toString
6ecdff6 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
abrokenjester added a commit to abrokenjester/spatial4j that referenced this issue Mar 9, 2020
@abrokenjester
locationtechGH-162 handle empty point / shape collection in toString
12f8b11 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
abrokenjester added a commit to abrokenjester/spatial4j that referenced this issue Mar 9, 2020
@abrokenjester
locationtechGH-162 handle empty point / shape collection in toString
028a36a 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
@abrokenjester abrokenjester mentioned this issue Mar 9, 2020
Merged
abrokenjester added a commit to abrokenjester/spatial4j that referenced this issue Mar 12, 2020
@abrokenjester
locationtechGH-162 handle empty point / shape collection in toString
689b41d 
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
dsmiley added a commit to abrokenjester/spatial4j that referenced this issue Mar 16, 2020
@dsmiley
Merge branch 'master' into locationtechGH-162-wktwriter-emptypoint
401f6d7
dsmiley added a commit that referenced this issue Mar 20, 2020
@abrokenjester @dsmiley
GH-162 handle empty point / shape collection in WKT, GeoJSON (#183)
6a43828 
* GH-162 handle empty point / shape collection in WKT

Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>

* Fix GeoJson too.  Test round-trip.

Co-authored-by: David Smiley <david.w.smiley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsmiley @abrokenjester