Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Confirmation dialogue window when removing a device from Favorites #1324

Open
sergd88 opened this issue May 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sergd88
Copy link
Contributor

sergd88 commented May 9, 2024

Is your feature request related to a problem? Please describe.

Lately, I've accidentally removed devices from Favorites a few times by tapping on the heart icon itself on the right (shown in the screenshot), even though the add/remove button is conveniently placed at the edge. Nevertheless, I still manage to accidentally tap it sometimes 😬 So, I think it wouldn't be a bad idea if, before removing from Favorites (by clicking on the heart icon), we also received a confirmation dialogue window, as it happens when deleting in edit/settings mode for Favorites, where we are asked if we really want to delete the device.

As for adding, perhaps it would be worth it to also immediately open the device settings window when when adding to Favorites (by clicking on the heart icon), just like it happens directly from the Favorites section. Then, if needed, you could immediately change the device name, as well as confirm adding the device to Favorites or cancel the addition if you accidentally tapped the heart icon. This would be more informative because perhaps not everyone is aware that there is the option to assign custom names to other devices, and, as mentioned earlier, it would completely eliminate accidental additions to Favorites.

Describe the solution you'd like

Described above.

Describe alternatives you've considered

No response

Additional context

1

@Tienisto Tienisto added the enhancement New feature or request label May 9, 2024
@Tienisto
Copy link
Member

Tienisto commented May 9, 2024

I agree that the behaviour should be made more explicit instead of only changing its icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants