Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnx.MatMul version 1 not lowered (but it's essentially the same as version 13) #3324

Closed
mgehre-amd opened this issue May 10, 2024 · 0 comments · Fixed by #3403
Closed

onnx.MatMul version 1 not lowered (but it's essentially the same as version 13) #3324

mgehre-amd opened this issue May 10, 2024 · 0 comments · Fixed by #3403
Assignees
@zjgarvey

Comments

@mgehre-amd
Copy link
Contributor

We support onnx.MatMul version 13, but not version 1, even though their difference is minimal: https://onnx.ai/onnx/operators/text_diff_MatMul_1_13.html

Could we please also support version 1?
This is relevant for older models, e.g. for running the ONNX conformance suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjgarvey zjgarvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Onnx] reduce MatMul OpsetVersion to 1 zjgarvey/torch-mlir
2 participants
@zjgarvey @mgehre-amd