Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JITLink] Reformat code due to an strict order of evaluation in C++17 #89472

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

orion160
Copy link
Contributor

current LLVM_REQUIRED_CXX_STANDARD=17

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@orion160 orion160 changed the title Reformat code due to an strict order of evaluation in C++17 [JITLink] Reformat code due to an strict order of evaluation in C++17 Apr 19, 2024
@orion160
Copy link
Contributor Author

It seems that there are other parts that can use the C++ 17 stablished ordering

@orion160
Copy link
Contributor Author

CC @lhames @vgvassilev

@vgvassilev vgvassilev requested a review from lhames May 17, 2024 17:19
@lhames
Copy link
Contributor

lhames commented May 18, 2024

Hi @orion160. Have you confirmed that MSVC handles this correctly?

If so the commit message should mention that we're removing an MSVC workaround (so that it's clear why this is only happening now).

@orion160
Copy link
Contributor Author

@lhames What is the policy for compiler version support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants