Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out ClockEdgeAttr definitions #7034

Open
fabianschuiki opened this issue May 14, 2024 · 1 comment
Open

Factor out ClockEdgeAttr definitions #7034

fabianschuiki opened this issue May 14, 2024 · 1 comment

Comments

@fabianschuiki
Copy link
Contributor

Quite a few of our dialects define a ClockEdgeAttr to allow ops to specify which clock edge they are sensitive to, such as posedge, negedge, and both edges. It would be great if we had one definition of ClockEdgeAttr somewhere, for example in the HW dialect, and then used that definition from all other dialects that need it.
@fabianschuiki fabianschuiki added the good first issue Good for newcomers label May 14, 2024
@fabianschuiki fabianschuiki mentioned this issue May 14, 2024
Merged
3 tasks
@maerhart
Copy link
Member

I took a look and came up with #7037. I thought they had added something like -attrdefs-dialect for enums as well, so this isn't as easy as I thought it was. 😞

@maerhart maerhart removed the good first issue Good for newcomers label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabianschuiki @maerhart