Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using PUSHAUTO for multistream #254

Open
victorges opened this issue Jan 25, 2023 · 0 comments
Open

Switch to using PUSHAUTO for multistream #254

victorges opened this issue Jan 25, 2023 · 0 comments

Comments

@victorges
Copy link
Member

As reported on #115, we sometimes get multistream crashing and not
reconnecting. This is by design, as Mist's PUSH abstraction is made to connect only once.

The fix is to switch to PUSHAUTO which handles the reconnect, and the only real complexity here (apart from
changing the object type) is making sure that we delete these pushes when the stream ends, otherwise they will leak
in mist (and if stream restarts even get duplicated and cause a mess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant