Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace web3 methods with ethers.js #577

Open
RiccardoBiosas opened this issue May 16, 2022 · 0 comments · May be fixed by #590
Open

Replace web3 methods with ethers.js #577

RiccardoBiosas opened this issue May 16, 2022 · 0 comments · May be fixed by #590
Assignees

Comments

@RiccardoBiosas
Copy link
Contributor

Context
The code-base uses both web3 (i.e.: here, here and here) and ethers.js method, and as mentioned here we should converge towards consistently using ethers.js. In the process, I think it'd be valuable to make the code more flexible should we swap tools again in the future.

Proposal

  • create wrapper/adapter class that will encapsulate all the recurring web3.js/ethers.js methods so that the consumers (tests, scripts etc.) are not directly exposed to the dependencies
  • use ethers.js methods within the wrapper/adapter entity
  • replace the occurrences of web3/ethers.js methods with the corresponding methods in the wrapper entity
  • remove web3-related dependencies from the code (tests, scripts, package.json etc.)
@kautukkundan kautukkundan self-assigned this May 24, 2022
@kautukkundan kautukkundan linked a pull request Jun 1, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants