Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the javascript code to typescript #569

Open
RiccardoBiosas opened this issue May 10, 2022 · 0 comments
Open

Convert the javascript code to typescript #569

RiccardoBiosas opened this issue May 10, 2022 · 0 comments

Comments

@RiccardoBiosas
Copy link
Contributor

Context
A lot of the protocol tests are implemented in javascript, which is very error-prone - especially when it comes to its lack of type safety.

Proposal
I think that moving from javascript to typescript might be worth the effort. The priority, however, should be not to break any of the existing logic/tests. One way we could gradually tackle the javascript<>typescript refactoring might be related to #568, whereby we could start writing the shared behaviors of the tests in typescript right away and then 'plug them in' the existing test suites & replace the javascript parts

@RiccardoBiosas RiccardoBiosas changed the title Convert javascript to typescript Convert the javascript code to typescript May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant