Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remote transcoding tests in orch_test.go to remove time.sleep #2756

Open
eliteprox opened this issue Feb 13, 2023 · 0 comments
Open
Labels
type: tech debt chores, performance improvements, etc

Comments

@eliteprox
Copy link
Contributor

eliteprox commented Feb 13, 2023

Is your feature request related to a problem? Please describe.
Remote transcoding tests might be flaky due to a time.sleep required with go-routines to connect remote T for testing.
There are currently 5 such tests:

func TestServeTranscoder(t *testing.T) {

func TestManageTranscoders(t *testing.T) {

func TestSelectTranscoder(t *testing.T) {

func TestCompleteStreamSession(t *testing.T) {

func TestTranscoderManagerTranscoding(t *testing.T) {

Describe the solution you'd like
Refactor remote transcoding tests inside of orch_test.go to allow for remote transcoders to be connected without using go-routines or time.sleep. As recommended in #2747. One additional test should be added once resolved. I've published this to my branch here: https://github.com/eliteprox/go-livepeer/tree/develop-trancoderdrop-tests

Describe alternatives you've considered
Considered leaving the time.sleep in the tests, decision made to not add the new test at this time.

Additional context
None

@github-actions github-actions bot added the status: triage this issue has not been evaluated yet label Feb 13, 2023
@yondonfu yondonfu added type: tech debt chores, performance improvements, etc and removed status: triage this issue has not been evaluated yet labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tech debt chores, performance improvements, etc
Projects
None yet
Development

No branches or pull requests

2 participants