Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor selection logic in broadcast.go into selection.go selectors #2669

Open
yondonfu opened this issue Nov 28, 2022 · 0 comments
Open

Refactor selection logic in broadcast.go into selection.go selectors #2669

yondonfu opened this issue Nov 28, 2022 · 0 comments

Comments

@yondonfu
Copy link
Member

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

See the following comment from #2666

Outside of this PR I think it would be a good idea to do a refactor to move as much selection logic (i.e. last session tracking, segment in flight tracking, etc.) into MinLSSelector in selection.go to keep that logic encapsulated in a single place. This felt like a hefty change though so I opted not to do that refactor in this PR.

Describe the solution you'd like
A clear and concise description of what you want to happen.

I think encapsulating as much selection logic into selectors in selection.go would reduce code management in broadcast.go and allow us to just call selectors to get the next O to use without the caller needing to be exposed to how the selector is determining which O to return.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@github-actions github-actions bot added the status: triage this issue has not been evaluated yet label Nov 28, 2022
@leszko leszko removed the status: triage this issue has not been evaluated yet label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants