Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory NodeStorage may create very limited historical #67

Open
ad-astra-video opened this issue Apr 24, 2024 · 1 comment
Open

Memory NodeStorage may create very limited historical #67

ad-astra-video opened this issue Apr 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ad-astra-video
Copy link

Describe the bug

My understaning is drivers.NodeStorage is set in starter.go on line 1254 to a MemoryDriver with a cache length of 12. I think the current implementation of [capability]_[model] in the AI selector as the session name will be limited to 12 results before cache starts to clear. This could result in ErrNotFound errors when more than 12 requests are done before the 1st request could be downloaded.

Reproduction steps

Send 13 requests to ByteDance/SDXL-Lightning model and try to download first image. Expect to get ErrNotFound.

Expected behaviour

A session pool per request would solve this and limiting inference requests to 12 per request.

Severity

None

Screenshots / Live demo link

No response

OS

None

Running on

None

AI-worker version

No response

Additional context

No response

@ad-astra-video ad-astra-video added the bug Something isn't working label Apr 24, 2024
@rickstaa
Copy link
Contributor

rickstaa commented May 8, 2024

Tracked internally at https://linear.app/livepeer-ai-spe/issue/LIV-270.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants