Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lenovo Thinkpad T530-unmaintained-build for testing and reporting functionality of build #1672

Closed
fhvyhjriur opened this issue May 13, 2024 · 4 comments · Fixed by #1673
Assignees

Comments

@fhvyhjriur
Copy link

I bought for heads-testing a T530 like i announced it here #925 (comment) .
T530 was supported by heads but was not tested for longer time and thats why it got disabled. Now there are no actual builds for the T530 to test it again.
@tlaurion
Could you enable the T530-maximized images to test? You have done it few days ago for the kgpe-d16 here e4976e7

I could then flash the bottom and top image to the two spi chips of the T530 and report if its working.

tlaurion added a commit to tlaurion/heads that referenced this issue May 13, 2024
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion added a commit to tlaurion/heads that referenced this issue May 13, 2024
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
@tlaurion
Copy link
Collaborator

@fhvyhjriur see #1673

@tlaurion
Copy link
Collaborator

And then, since the commit from where that board became untested and then unmaintained, check what changed in board config compared to its x230-maximized board equivalent under board config and make sure everything is in sync even if it was untested.

Report your findings. Iterate.

if this one works, it means that UNMAINTAINED-t530-hotp-maximized should work as well.

On top of my head, HOTP autoboot is missing in board config.
To iterate with other changes comapring the board config files.
To iterate comparing coreboot config pointed by x230/t530 etc.

tlaurion added a commit to tlaurion/heads that referenced this issue May 13, 2024
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
@tlaurion
Copy link
Collaborator

7d67d5a oups. Bad board name.
Fixed under 1035a93

@fhvyhjriur
Copy link
Author

Thanks for the images. Test report can be found here: #1682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants