Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create seperate targets/*.mk files: Add TPM1/TPM2/HOTP/Common/whiptail/fbwhiptail/tethering others. #1643

Open
tlaurion opened this issue Apr 19, 2024 · 0 comments

Comments

@tlaurion
Copy link
Collaborator

tlaurion commented Apr 19, 2024

As the refactoring of qemu boards that was done under #1642 showed for those boards to be used as reference, since they represent most of existing board flavors today, maintening them just makes no sense anymore.

The solution forward, as started already, is to have common goals mk files under targets dir, and for boards to just pick those targets into the board configurations, and where extensive documentation could then be inside of those target sub-Makefiles.

The qemu-coreboot* boards can easily be used as a base to do that forward.

Until then, when changes related to specific board configs, please compare your board to those reference boards to understand what makes what.

Ideally in the future, those sub-makefiles could also test things out prior of building a non-working board.
For example today, enabling tethering for a board without having the kernel config file adding those modules will fail at build time.
The Makefile could parse the Kconfig file, and tell which Kconfig options are missing, refusing to build the board. or even call internal helpers added to add those Kconfig options to the pointed config file for the developer to simply verify prior of commiting and pushing changes upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant