Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LUKS container re-encryption and OEM factory reset process #1538

Open
UndeadDevel opened this issue Nov 25, 2023 · 0 comments · May be fixed by #1547
Open

Improve LUKS container re-encryption and OEM factory reset process #1538

UndeadDevel opened this issue Nov 25, 2023 · 0 comments · May be fixed by #1547

Comments

@UndeadDevel
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. When doing the LUKS container re-encryption, either by itself or as part of OEM factory reset, the new password(s) are displayed as plain text on screen and will stay there until the process is complete, which can take some time with a large drive that needs to be fully re-encrypted; this is fine when there is no chance of anyone seeing the screen in this time, but many people live together with others in the same space and in those cases it's inconvenient to have the secrets displayed for so long and have to cover the screen with a towel or similar.
  2. After doing the re-encryption the user must sign all checksums again, but I didn't see this being communicated (maybe I missed it?). This should be part of the information given to the user or the user should be prompted to do it after the process completes (this is regarding LUKS re-encryption by itself, as I think OEM factory reset already does that).

Describe the solution you'd like

  1. I would suggest clearing the screen at once (perhaps a warning about this and ask user confirmation; there is still the summary window anyway, though currently there's a bug about it).
  2. Prompt the user to sign all files and checksums after doing a LUKS-container re-encryption.

Describe alternatives you've considered

  1. Perhaps having the re-encryption process "push" the text up (i.e. insert newlines) periodically, e.g. once every 10 seconds so that the secrets will all disappear from screen in 2 or 3 minutes.
  2. Put some info on screen telling user to sign checksums after LUKS container re-encryption.
@UndeadDevel UndeadDevel linked a pull request Dec 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant