Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct linkml_files.URL_FOR - add URL resolutiontests #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct linkml_files.URL_FOR - add URL resolutiontests #320

wants to merge 1 commit into from

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Apr 3, 2024 •
edited

Continues: #310
Fix: linkml/linkml#2047

Previously I had fixed some problems with linkml_files but didn't test the URL_FOR function. This is used by the ContextGenerator and RDFGenerator, and causes linkml tests and fail and breaks them.

This PR

  • fixes URL_FOR
  • switches tests to pytest
  • Add requests_cache
  • Unskip tests for URL resolution and correctness - these are ~slow-ish, but since we're using them upstream i figure we should test them.
  • Skip fail-prone and unused github URL tests - I can't see where these functions are used within the library and they give us 403's constantly, we might want to remove those? i mostly care about the local path functions here, but also i don't think we should have broken stuff lying around if we can help it

edit: confirmed this does fix test_generators/test_rdfgen.py

@sneakers-the-rat
Correct URL_FOR
df1a56e 
- Unskip tests for URL resolution and correctness
- Skip fail-prone and unused github URL tests
- Add requests_cache
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (0f99716) to head (df1a56e).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   62.70%   64.35%   +1.64%     
==========================================
  Files          63       63              
  Lines        8580     8612      +32     
  Branches     2444     2447       +3     
==========================================
+ Hits         5380     5542     +162     
+ Misses       2583     2456     -127     
+ Partials      617      614       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linkml-files gives incorrect URIs for JSON-LD contexts
2 participants
@sneakers-the-rat @cmungall