Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaclgen not generating nodeKind/datatype #1299

Closed
noelmcloughlin opened this issue Feb 20, 2023 · 1 comment · Fixed by #2102 · May be fixed by #1300
Closed

shaclgen not generating nodeKind/datatype #1299

noelmcloughlin opened this issue Feb 20, 2023 · 1 comment · Fixed by #2102 · May be fixed by #1300
Labels
bug Something that should work but isn't, with an example and a test case. community-generated generator-dataclasses Python classes were generated by dataclass (we are mostly switching to Pydantic, though)

Comments

@noelmcloughlin
Copy link
Contributor

noelmcloughlin commented Feb 20, 2023 •
edited

Describe the bug

The artifacts generated by shaclgen.py are missing nodeKind and datatype for linkml types. During debugging this conditional is always false and inner block is skipped:

linkml/linkml/generators/shaclgen.py

Line 112 in ec93623

elif r in sv.all_types().values():

To reproduce
Using linkml-project-cookiecutter you can run gen-shacl and example schema and examine types ("sh:property") nodes.

Expected behavior

I'd expect to see sh:nodeKind and sh:datatype generated for linkml types.
@noelmcloughlin noelmcloughlin added the bug Something that should work but isn't, with an example and a test case. label Feb 20, 2023
@noelmcloughlin noelmcloughlin mentioned this issue Feb 20, 2023
Open
@noelmcloughlin
Copy link
Contributor Author

Draft PR: #1300

@nlharris nlharris added the generator-dataclasses Python classes were generated by dataclass (we are mostly switching to Pydantic, though) label Feb 21, 2023
@jsheunis jsheunis mentioned this issue Mar 28, 2024
Closed
@jsheunis jsheunis mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that should work but isn't, with an example and a test case. community-generated generator-dataclasses Python classes were generated by dataclass (we are mostly switching to Pydantic, though)
Projects
None yet
Milestone
No milestone
3 participants
@nlharris @sierra-moxon @noelmcloughlin