Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only light curves from SPOC or TESS-SPOC have their fluxes as MaskedQuantities #1339

Open
Nschanche opened this issue May 24, 2023 · 2 comments
Labels
🤿 masked array problems This is an issue with the numpy or astropy masked arrays 🥏 discussion
Milestone

Comments

@Nschanche
Copy link
Collaborator

It seems that, on my end at least, this error only occurs with very specific light curves for some reason. It will not run if the flux's type is a MaskedQuantity. After trying out some different light curves for mu Eridani, it seems that only light curves from SPOC or TESS-SPOC have their fluxes as MaskedQuantities:

Screenshot 2023-05-24 at 2 00 14 PM

I haven't tested this with other stars. Does this happen to anyone else as well?

Originally posted by @Paco-2000 in #1338 (comment)

@Nschanche Nschanche added 🐛 bug Something isn't working 🤿 masked array problems This is an issue with the numpy or astropy masked arrays labels May 24, 2023
@Nschanche
Copy link
Collaborator Author

Note, the original issue was resolved by updating to astropy 5.3. However, I think this is still an issue as I'm not sure whether the MaskedQuantity vs Quantity data type difference is intentional.

@Nschanche Nschanche added 🥏 discussion and removed 🐛 bug Something isn't working labels May 24, 2023
@christinahedges christinahedges added this to the 2.5 milestone Nov 3, 2023
@orionlee
Copy link
Collaborator

orionlee commented Nov 4, 2023

In terms of the actual codes, lightkurve does not do anything SPOC / TESS-SPOC specific to return MaskedQuantity. It seems to be a by-product of the a) specific FITS format used by SPOC / TESS-SPOC and b) astropy FITS reader behavior.

If it's decided to use Quantity instead of MaskedQuantity, PR #1281 would provide a fix.

I think using Quantity (instead of MaskedQuantity) will alleviate the various quirks / bugs / API differences with MaskedQuantity.
For users who have specific requirement to use MaskedQuantity, they can still convert the columns to MaskedQuantity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤿 masked array problems This is an issue with the numpy or astropy masked arrays 🥏 discussion
Projects
None yet
Development

No branches or pull requests

3 participants