Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format in Zypp History in the Qt Package Selector does not follow locale #60

Open
embar- opened this issue Nov 24, 2021 · 2 comments

Comments

@embar-
Copy link

embar- commented Nov 24, 2021

Zypp History in the Qt Package Selector has problem with date in some locales. E.g. for Lithuanian, it shows "24 lapkričio 2021" - seems merely translated from English format "24 November 2021" (DD Month YYYY), however such date expression is incorrect in Lithuanian language (we never say in Lithuanian in such way and is error according to Lithuanian language grammar too, not only by date format itself). The long date format in Lithuania is "YYYY m. month DD d." (e.g. "2021 m. lapkričio 24 d.") and official Lithuanian short date format is the same as an ISO "YYYY-MM-DD" (e.g. 2021-11-24). Thus Zypp History in the Qt Package Selector should not force English date format, but use locale-dependent date format – either short format (preferably) or long format (as is in other Qt Packager places like RPM Changelog, Technical details). This problem related to #51

@embar-
Copy link
Author

embar- commented Nov 24, 2021

paveikslas

@shundhammer
Copy link
Contributor

That appears to be done here:

https://github.com/libyui/libyui/blob/master/libyui-qt-pkg/src/YQPkgHistoryDialog.cc#L265

going back all the way to 2012, i.e. 10 years ago:

https://github.com/libyui/libyui/blame/83729345940f41c1f834d507c5fc9787e33a59e0/libyui-qt-pkg/src/YQPkgHistoryDialog.cc#L187

And yes, I also find those date formats annoying; it's also totally unusual in German to spell the month name out, it's never "3. Februar 2022", it's always "3.2.2022" or "03.02.2022". But at least it doesn't leave the user guessing if it's that weird American date format ("2/3/2022") where the month comes first, then the day, then the year, or the normal order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants