Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rate limit headers in 404 responses #2860

Open
calebcartwright opened this issue Sep 27, 2021 · 2 comments
Open

Include rate limit headers in 404 responses #2860

calebcartwright opened this issue Sep 27, 2021 · 2 comments

Comments

@calebcartwright
Copy link

Suppose this counts as a feature request, but I've observed that the API response doesn't include the rate limiting headers in not found/404 scenarios, and was curious if it would be feasible to include those response headers (x-ratelimit-limit, x-ratelimit-remaining) in the 404 scenarios as well?

e.g. compare

curl -I https://libraries.io/api/npm/not-a-real-package-anywhere/latest/dependencies 

with

curl -I https://libraries.io/api/npm/badge-maker/latest/dependencies

The 404 request definitely counts against the rate limit, and the absence of the headers is consistent regardless of whether the request is authenticated with the api_key query param.

Thanks in advance for your consideration (and the Libraries.io service!), and please let me know if more information is required and/or any of the above is unclear.

@M00NZ1R94
Copy link

Ron said he would have to wait for a couple more days for a new contract and he will not let us have the money to get back from him

@Samric24
Copy link

Samric24 commented Jan 3, 2024

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants