Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the precision level in the lens equation solver between time delays and image positions #184

Open
jiwoncpark opened this issue Jun 11, 2020 · 1 comment

Comments

@jiwoncpark
Copy link
Collaborator

When combining 100s of simulated PEMD lenses, the H0 recovery precision (0.4%) approaches a point where the numerical precision level of the lens equation solver starts to matter. My solution for forcing the precision level to be the same between the image positions and time delays has simply been to have the TDCosmology's time_delays method return the image positions that were used to evaluate the time delays. But this will most likely break people's code -- this issue is meant to be a discussion more than a simple code fix!

@jiwoncpark jiwoncpark mentioned this issue Jun 11, 2020
sibirrer added a commit that referenced this issue Jul 25, 2020
…r, kwargs_lens_eqn_solver on the level of the model settings in kwargs_model and adopted the backend of the PointSource module. This addresses issue #184 and should also make the PR #185 redundant.
@sibirrer
Copy link
Collaborator

@jiwoncpark I updated the design such that all the lens equation solver specific arguments are part of kwargs_lens_eqn_solver within the kwargs_model arguments and those should be able to be passed to all relevant classes self-consistently, including the ones in the Analysis module. This should also make PR #185 redundant. Let me know if you have questions and whether you want to keep this issue open. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants