Zero-point magnitude definition

[aymgal]

I'd like to check the consistency of magnitudes and units in e.g. the SimulationAPI module. Assuming I generate mock in units of electrons per second, as far as I understand in lenstronomy, the input zero-point point magnitude is assumed to be the magnitude corresponding to 1 electron per second per arcsec^2. But when I see the values used e.g. in the ObservationConfig submodule -- for instance with LSST, z-band, it is 27.4 (also from this doc) -- those are for 1 electron per second per pixel.

So does this mean that everything is consistent in the API but simply some docstrings (like this one) need to be fixed, or is there some deeper inconsistency somewhere?

[sibirrer]

ah, the magnitude zero point does not have a 'per area' unit. If a source (extended or point source) has a magnitude of the zero point, the total number of electron from that object hitting the detector =1. The per unit (arc seconds) statement is only applicable for sky brightness

[aymgal]

Ok thanks, I pushed a little fix to the docstring #553