Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genome build #4

Open
legaultmarc opened this issue Jan 30, 2015 · 1 comment
Open

Genome build #4

legaultmarc opened this issue Jan 30, 2015 · 1 comment

Comments

@legaultmarc
Copy link
Owner

As the codebase slowly grows, it becomes more important to make sure we have a standard and robust way to handle different genome builds.

I am currently worried about lines like this one:

    elif build == "GRCh38":
            url = ("http://rest.ensembl.org/variation/homo_sapiens/{snp}"
                   "?content-type=application/json")

which assume that the default is GRCh38. This is true, for now, but when it changes it will be very hard to maintain. I think that such default URLs should be centralized in the respective db module. A general rule should be that no hard coded URLs should be found anywhere but the db package.

Also, testing of the functionality on different builds is not thorough at this point (it is fairly inexistent actually). This should also be fixed...

@legaultmarc
Copy link
Owner Author

Started transitioning all the Ensembl REST API requests by using the db.ensembl.get_url_prefix function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant