First off, thank you for considering contributing to this repo. It's people like you that make this material such a great tutorial.
If you've noticed a bug, a feature or have a question go ahead and open an issue!
- Ensure the bug was not already reported by searching all issues.
If this is something you think you can fix, then fork digital_video_introduction and create a branch with a descriptive name.
A good branch name would be (where issue #325 is the ticket you're working on):
git checkout -b 325-add-japanese-translationsAt this point, you're ready to make your changes!
At this point, you should switch back to your master branch and make sure it's up to date with Active Admin's master branch:
git remote add upstream git@github.com:leandromoreira/digital_video_introduction.git
git checkout master
git pull upstream masterThen update your feature branch from your local copy of master, and push it!
git checkout 325-add-japanese-translations
git rebase master
git push --set-upstream origin 325-add-japanese-translationsFinally, go to GitHub and make a Pull Request :D
A PR can only be merged into master by a maintainer if:
- It was reviewed.
- It is up to date with current master.
Any maintainer is allowed to merge a PR if all of these conditions are met.
PS: this contributing text was inspired by active admin contributing.