Add loglevel to PyLoihiProcessModel.__init__ #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-shea
requested review from
mgkwill,
mathisrichter,
bamsumit and
PhilippPlank
bamsumit
reviewed
Aug 2, 2023
| def __init__(self, proc_params: ty.Optional["ProcessParameters"] = None): | ||
| super().__init__(proc_params=proc_params) | ||
| def __init__(self, proc_params: ty.Optional["ProcessParameters"] = None, | ||
| loglevel: ty.Optional[int] = logging.WARNING): |
There was a problem hiding this comment.
Is this complete? Don't we need to flow the loglevel when creating instances of processmodels during compilation?
There was a problem hiding this comment.
Do we? I'm really not sure. I got frustrated when I realized how entangled the loglevel stuff is throughout a million different places and gave up. I guess we could just close this as it's not really very important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #760
Objective of pull request: Add loglevel paramater to PyLoihiProcessModel constructor
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?