Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit breaker panel memory leak (?) #3304

Open
ignasi35 opened this issue Aug 30, 2021 · 0 comments
Open

Circuit breaker panel memory leak (?) #3304

ignasi35 opened this issue Aug 30, 2021 · 0 comments

Comments

@ignasi35
Copy link
Contributor

While reviewing proposal to port CircuitBreakersPanel from Lagom to akka/akka I think I saw a memory leak.

Circuit breakers may be added to the panel's breakers ConcurrentHashMap but are never removed.

It is rare for Lagom users to access the CircuitBreakersPanel and there'll probably only be as many instances as downstream lagom services. But the CircuitBreakersPanel may be used to arbitrarily create instances thus leaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant