Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapFuture with ec.prepare() #3300

Open
WayneWang12 opened this issue Aug 24, 2021 · 0 comments · May be fixed by #3315
Open

mapFuture with ec.prepare() #3300

WayneWang12 opened this issue Aug 24, 2021 · 0 comments · May be fixed by #3315

Comments

@WayneWang12
Copy link
Contributor

In module lagom-server, there is one line of mapFuture like:

    inMemoryBodyParser(playRequestHeader).mapFuture {
      ... // code is omitted
    }

The same operation in play, mapFuture is with ec.prepare() which like:

    parser(rh).mapFuture {
        ... // code is omitted
    }(ExecCtxUtils.prepare(executionContext))

Can lagom obey the same behavior with play? Context is that I'm doing a ContextPropagating which like a RequestContext in asynchronous environment. And mapFuture without ec.preprare() makes it impossible.

@WayneWang12 WayneWang12 linked a pull request Sep 27, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant