Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates are not picked under Issue, R12 #127

Open
mdengusiak opened this issue May 31, 2018 · 5 comments
Open

Duplicates are not picked under Issue, R12 #127

mdengusiak opened this issue May 31, 2018 · 5 comments

Comments

@mdengusiak
Copy link
Member

I found this example I mentioned before. We have two duplicates are not picked under Issue - Duplicate Surfaces
Panel 470 and Panel 381 in Space 00_153

image

Space00_153.zip

@theo-armour
Copy link
Member

@mdengusiak

Thenk you for sending the test file.

In this file both spaces and building storeys have spaces in their IDs

Line 16: <Space zoneIdRef="ZoneID" conditionType="Unknown" buildingStoreyIdRef="Level 00" id="00_100 Studio_1">

Spaces cause issues. See https://stackoverflow.com/questions/2277297/can-xml-attributes-have-spaces

These errors seem to be preventing both the Reports panel and the Issues panels from completing successfully.

We probably can get the Viewer to flag these errors more carefully. Maybe we could replace the spaces with a hyphen. But I hesitate adding this sort of slowdown unless we come across this issue fairly frequently.

So far we have only seen this problem in you SAM files. Is there anyway you can prevent the SAM files from doing this?

By the way, please note that the file also has CAD Object ID errors.

@mdengusiak
Copy link
Member Author

mdengusiak commented Jun 2, 2018

@theo-armour

thanks for catching this
I updated my code and we do not have spaces in IDs

Line 16:
<Space zoneIdRef="ZoneID" conditionType="Unknown" buildingStoreyIdRef="Level-00" id="00_001-WC">

Still Report panel is not working for me
SAM_1.zip

@mdengusiak
Copy link
Member Author

Sorry I forgot to fix adj spaces so this solution is now working. I can run Reports and Issue both in R12 and R13,
I will try to prepare new file with this overlap issue
SAM_3.zip

@mdengusiak
Copy link
Member Author

ok..

I have file with two issues... each surface is missing top adjusency
I am trying to attach each surface to Space 0M_145 and I can do this in viewer but when I save try to open again it does not work.
What should be order for saving in R13?

SAM_UoW_TASfix2.zip

image

@theo-armour
Copy link
Member

@mdengusiak

There are several issues with these surfaces.

Exposed to Sun should be set to false not true.

Interior floors should have two adjacent spaces not one.

Therefore trying to fix something that is quite broken is likely to lead to issues. Best to just edit the XML text for now. In the future there should be a fix button for missing adjacent spaces. Ditto incorrect 'exposed to Sun' values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants