馃椇 Include GeoNames to verify admin boundaries #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattigrthr
added
enhancement
|
The city names are matched based on OSM and GeoNames. I'm already using it in the |
mattigrthr
force-pushed
the
features/admin_boundaries_geonames
branch
3 times, most recently
from
3d63723
to
99f3f21
Compare
ephe-meral
force-pushed
the
features/admin_boundaries_geonames
branch
from
99f3f21
to
8a68bb5
Compare
|
Updated & pushed, should be ready for review @mattigrthr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
We are downloading city names from GeoNames as described in the issue to improve the admin boundaries' quality further.
I've added a downloader for the GeoNames file in the
admin-boundariespipeline, transforming the originaltxtfile into the Parquet format.The Parquet result is then imported into a new table in Postgres called
admin_boundary_geonames_cities.Now, I will use dbt to combine the OSM admin-boundary hierarchy with the city names.