Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting error on comments #83

Open
jackhkmatthews opened this issue Apr 5, 2018 · 3 comments
Open

Linting error on comments #83

jackhkmatthews opened this issue Apr 5, 2018 · 3 comments

Comments

@jackhkmatthews
Copy link

jackhkmatthews commented Apr 5, 2018

Expected Behaviour

Comments within GraphQL schemas to pass linting.

Current Behaviour

Comments throw a [graphql] Syntax Error: Unexpected String error.

screen shot 2018-04-05 at 15 08 21

Otherwise excellent plugin, any help much appreciated!

kumarharsh pushed a commit that referenced this issue May 2, 2018
- adds support for multi-root workspaces. Closes #33
- interfaces with @playlyfe/gql v3. Closes #83
- can auto-download gql library if not found. Addresses #16

other changes:
- update language server to v4.
- add prettier and format extension code.

BREAKING_CHANGES: the extension options have changed.
You'll need to go into your settings page, and configure these options:
* graphqlForVSCode.autoDownloadGQL: auto download @playlyfe/gql if not
* graphqlForVSCode.gqlPath: An absolute path to @playlyfe/gql module, if
not auto-downloaded. If the library is located at the path
`${workspaceRoot}/src/ui/node_modules/@playlyfe/gql`, you need to set
the gqlPath as `${workspaceRoot}/src/ui`.
* graphqlForVSCode.configDir: An absolute path to directory containing
the `.gqlConfig` file. You can use `${workspaceRoot}` to specify the
root.
* graphqlForVSCode.watchman: use fb-watchman to watch files _if available_
kumarharsh pushed a commit that referenced this issue May 4, 2018
- adds support for multi-root workspaces. Closes #33
- interfaces with @playlyfe/gql v3. Closes #83
- can auto-download gql library if not found. Addresses #16

other changes:
- update language server to v4.
- add prettier and format extension code.

BREAKING_CHANGES: the extension options have changed.
You'll need to go into your settings page, and configure these options:
* graphqlForVSCode.autoDownloadGQL: auto download @playlyfe/gql if not
* graphqlForVSCode.gqlPath: An absolute path to @playlyfe/gql module, if
not auto-downloaded. If the library is located at the path
`${workspaceRoot}/src/ui/node_modules/@playlyfe/gql`, you need to set
the gqlPath as `${workspaceRoot}/src/ui`.
* graphqlForVSCode.configDir: An absolute path to directory containing
the `.gqlConfig` file. You can use `${workspaceRoot}` to specify the
root.
* graphqlForVSCode.watchman: use fb-watchman to watch files _if available_
@zvirja
Copy link

zvirja commented Jul 25, 2018

@kumarharsh @Mayank1791989 Could you please clarify the status of this issue? Do we have any workaround for it? It's pretty annoying, as currently we use graphql-cli to generate the schema files and need to manually post-process files so that extension parses it... 😟

Thanks.

@kumarharsh
Copy link
Owner

Thank you for your inputs. I understand your pain and annoyance. This issue directly depends the release of the gql v3 (which supports the newer graphql versions). Discussion for which is on #42. Good news is that @Mayank1791989 has made significant progress on the watcher front for the gql library which this plugin depends on. Once that is completed, we will go ahead with a new release which will solve this issue.

@ChristianIvicevic
Copy link

The release of gql v3 which supposedly fixes this particular issue is underway for more than a year now (dating back to September 2017, right?). Any information on the fix for comment linter errors? Otherwise I'll have to revert back to the Apollo plugin for VSCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants