Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sidecar Containers] Sidecar containers finish time needs to be accounted for in job controller #124937

Open
SergeyKanzhelev opened this issue May 17, 2024 · 2 comments · May be fixed by #124942
Open

[Sidecar Containers] Sidecar containers finish time needs to be accounted for in job controller #124937

SergeyKanzhelev opened this issue May 17, 2024 · 2 comments · May be fixed by #124942
Assignees
@AxeZhan
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@SergeyKanzhelev
Copy link
Member

What happened?

Today the function getFinishTimeFromContainers (pkg/controller/job/backoff_utils.go) only account for the regular containers finish time,
presumably assuming that init containers have completed before before.
However, with the sidecar (restartable init) containers, sidecar containers will always finish later than
regular containers. And those needs to be accounted for the calculation.

/kind bug

What did you expect to happen?

The sidecar finish time will be accounted when calculating the job's finish time.

How can we reproduce it (as minimally and precisely as possible)?

Sidecar container with prolonged termination logic on a job will result in incorrect finish time reporting.

Anything else we need to know?

/sig apps
/priority backlog
KEP: kubernetes/enhancements#753
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. priority/backlog Higher priority than priority/awaiting-more-evidence. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@AxeZhan
Copy link
Member

AxeZhan commented May 18, 2024

/assign

@AxeZhan AxeZhan linked a pull request May 18, 2024 that will close this issue
Open
@gjkim42
Copy link
Member

gjkim42 commented May 20, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxeZhan AxeZhan

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
4 participants
@SergeyKanzhelev @gjkim42 @k8s-ci-robot @AxeZhan