Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sidecar Containers] Eviction message should account for the sidecar containers #124938

Open
SergeyKanzhelev opened this issue May 17, 2024 · 3 comments · May be fixed by #124947
Open

[Sidecar Containers] Eviction message should account for the sidecar containers #124938

SergeyKanzhelev opened this issue May 17, 2024 · 3 comments · May be fixed by #124947
Assignees
@toVersus
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node Bugs

Comments

@SergeyKanzhelev
Copy link
Member

What happened?

The evictionMessage is not accounting for the restartable init containers (sidecars).

/kind bug

What did you expect to happen?

When pod is evicted, requests of the sidecar containers must be added to the annotations.

How can we reproduce it (as minimally and precisely as possible)?

Evict pod with the sidecars and check out annotation.

Anything else we need to know?

/sig node
/priority backlog
KEP: kubernetes/enhancements#753
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/backlog Higher priority than priority/awaiting-more-evidence. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@toVersus
Copy link

/assign

@toVersus toVersus linked a pull request May 19, 2024 that will close this issue
Open
@gjkim42
Copy link
Member

gjkim42 commented May 20, 2024

I guess we also need to take restartable init containers into account when we check the resource pressure not just for its message.

@gjkim42
Copy link
Member

gjkim42 commented May 20, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2024
@SergeyKanzhelev SergeyKanzhelev added this to Triage in SIG Node Bugs May 22, 2024
@haircommander haircommander moved this from Triage to Triaged in SIG Node Bugs May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toVersus toVersus

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node Bugs
Triaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Sidecar Containers] Consider restartable init containers in eviction message toVersus/kubernetes
4 participants
@SergeyKanzhelev @gjkim42 @k8s-ci-robot @toVersus