Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sync node status.images with pod #839

Open
wzshiming opened this issue Nov 15, 2023 · 8 comments
Open

Support sync node status.images with pod #839

wzshiming opened this issue Nov 15, 2023 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone

Comments

@wzshiming
Copy link
Member

What would you like to be added?

  • Support sync node status.images with pod
  • Add a flag to allow kwok-controller to enable this feature.

Why is this needed?

Refinement of simulated kubelet behavior

@wzshiming wzshiming added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2023
@wzshiming wzshiming added this to the v0.6 milestone Dec 18, 2023
@kevinmingtarja
Copy link

Hi, I'm interested to contribute to this feature.

Do you have any pointers on where to start? Thank you.

@wzshiming
Copy link
Member Author

wzshiming commented Dec 25, 2023

My idea would be to add a template function to node template that would look like this

images:
{{ with NodeImages status.images }}
{{ YAML . 1 }}
{{ end }}

The NodeImages return will contain the status.images and the images used by the pods on this node.

@caozhuozi
Copy link
Contributor

Hi, @wzshiming. Is the feature independent of v1alpha2?

@wzshiming
Copy link
Member Author

Hi, @wzshiming. Is the feature independent of v1alpha2?

Yes, It add a template function to the Node Controller

@caozhuozi
Copy link
Contributor

/assign

@wzshiming
Copy link
Member Author

#977 (comment)

I plan to add a new API that should cover this capability

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2024
@Manoramsharma
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
Status: 🆕 New
Development

No branches or pull requests

6 participants