-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: A hint for books in collections #11846
Comments
I was thinking of a transparent star, so that only its outline would be visible. But maybe sometimes it's not very distinct... |
I think that was just meant to show the concept, not a lack of transparency. Unless I'm misreading it. ^_^ |
It is indeed indistinct. |
I have to think before I speak... 🙂 |
Could it be a white-filled star with thick-black-borders and a transparent outside ? |
I think that's what I had in mind... |
Same, yes. ;-) |
With the white circle around it is probably clearer but either way seems okay. |
I would prefer the white-filled star with thick-black-borders and a transparent outside. The other one with the circle I think looks like an emblem. After all, on a white background only the star will be visible. |
Second one, for me. |
If the star with the circle will be preferred, I think the black star with the white circle would be better. |
The reason I think with the circle is slightly better is because otherwise it somewhat disappears into darker backgrounds. Perhaps one with an additional thin white line around it to see what that would look like? |
Added to the above post with screenshots. |
Yes, I've seen it. I didn't want you to give us a screenshot. |
Thin line - white circle, or thin line - white star outlining the black border of the star? |
Of the above options, my preference would be the 2nd one (star with no background). (Possibly the star could be enlarged a bit if it seems not discernible enough for some.) If a background, then I think a square background in the top-right corner (maybe with something like 50% opacity) would look better than a circle, as it would blend better with the rectangle-shaped cover. Star on circle on rectangle seems like a bit too many shapes in one per cover. |
The latter. |
We need an artist to draw the new svg icon for that. |
I personally tend to option 2. |
Option 2 is fine. |
Should we show a star when browsing a collection (all books would have the mark, obviously)? |
I spent a day with white circles as background, and they look very irritating. |
Seems unnecessary. |
The white circle is probably not the solution :) I get the same feeling with your circle screenshots. |
This is the correct solution. Also you see this in movie subtitles where background is unpredictable. A thick dark border with bright text has the best visibility.
Unfortunately this is the side effect, border joins either to foreground or background. Best solution is to provide a stable bg color as jonnyl2 said:
A dark square or a dogear to cover the star's background. In this case star can be just white too, since border wouldn't be necessary. Also I agree that star should be enlarged a bit as jonnyl2 said. |
Why not. Main idea is giving it a stable background so users can immediately recognize it without the book cover interfering with the outline of the star. Can we combine these two indicators, something like:
Since lower right corner is the least important part of the book cover (no title there, generally empty) we can use that corner for both indicators. |
Star in this last screenshot looks pleasant and easily recognizable to me. I see combining them might not be a good idea :) |
Can the square be made partially transparent to let some of the cover image shine through? |
This will probably interfere with the instant shape recognition of the star and will decrease the icon/background contrast. My perspective is that since we already ruin that corner of the cover, at least we can try to maximize ux effectiveness. I want to remind everyone that everything looks much nicer in screenshots with their perfect contrast and lighting until they meet the reality of our e-ink screens :) |
Largely disagree (well, not for partial transparency stuff), most things in that screenshot look much nicer on a real device. :-D |
I meant nicer as "close to ideal contrast ratio and grayscale palette". Two shades of gray that look distinct on screenshots can turn into a greyish blob in real world conditions. Also they are on a perfect white background which is only (approximately) achievable under direct sunlight with e-ink screens. |
After Frenzie's comment I got curious about "why e-ink looks nicer?" and found this relatively old study. Although they didn't specifically studied e-ink, I found their results fascinating and wanted to share this useful information with my fellow e-ink enthusiasts. According to their findings, a recent generation e-ink screen in an office with standard lighting (this is approximate because I calculated/converted) has the optimal contrast ratio for comfortable reading. I guess this explains why these screens are less tiring (which I was always curious about). Probably colors on other screen types like LCD can be adjusted for a similar improvement but the advantage of e-ink comes from its nature. Apparently when we put pure black text on pure white background on an e-ink screen, we automatically reach this optimum reading contrast because the substrate softens both ends (black and white) acting as a natural clamp filter. As a speculation, I think this means probably we reached the peak with the current gen grayscale screens and all the improvements from now on will come from the color e-ink technology. Here is the link to the study if you want to read the details: |
It looks pretty good. Thank you! |
This issues has been discussed here.
Now that the collection feature has been added (thank you for this), there is the following "problem": Even if a book has been added to a collection, in the pop-up window, after long pressing on a book, there is the option "add to collection". So we can't know, even with this practical way, if the book has been added to a collection. I mean, when only Favorites existed, this was a way to see it, as, in case that the book had been added to Favorites, there was the option "Remove from Favorites" (something like that).
So, now there is need for a hint (both for list and mosaic mode) that will indicate if a book has been added to a collection.
@hius07 I remind your promise 🙂
Thank you!
The text was updated successfully, but these errors were encountered: