Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Adding margins when reading comics #11836

Open
pawanbasnet opened this issue May 17, 2024 · 6 comments
Open

FR: Adding margins when reading comics #11836

pawanbasnet opened this issue May 17, 2024 · 6 comments

Comments

@pawanbasnet
Copy link

Does your feature request involve difficulty completing a task? Please describe.
I read my comics on a desktop using monitor. Currently using fit height makes the page size really small to read and fit width make each page really stretched out across entire monitor width. Having a option to add margin to each side of comic reader much like book reader would help medicate the issue so it gives users more control of comic reader size

Describe the solution you'd like
I believe having a margin option would help resize the display for comics pages so they are not super stretched out across entire monitor.

Describe alternatives you've considered
Alternatives that I am currently using is opening Kavita in its own window and resizing the Firefox window to the size that comic book is ideal for reading. If I am binge reading for longer period, I also edit the CSS file to increase the margin size for the page. It does revert again if I refresh or back out of reading though.

Additional context
Add any additional context or screenshots about the feature request here.
Screenshot 2024-05-16 182201

@offset-torque
Copy link

I am trying to understand this pawanbasnet:
If you are using KOReader on desktop, why don't you resize your window horizontally to a comfortable size?
Why your KOReader window has to cover your whole screen horizontally?

@Frenzie
Copy link
Member

Frenzie commented May 17, 2024

I can imagine that a nice solid margin is nicer than window borders.

But more to the point, the bottom menu already has a margin setting. ;-)

@Frenzie Frenzie closed this as completed May 17, 2024
@Frenzie Frenzie reopened this May 17, 2024
@jonnyl2
Copy link

jonnyl2 commented May 17, 2024

But more to the point, the bottom menu already has a margin setting. ;-)

Not sure if there's anything different for comics/image-files, but on PDF/DJVU, that bottom menu margin setting can only remove margins, but not add them. I also sometimes would like to add extra margins when reading scanned PDF/DJVU books. To achieve that, I have to use a zoom factor, e.g. 0.9, from the 3rd tab in the bottom menu instead.

@Frenzie
Copy link
Member

Frenzie commented May 17, 2024

Right, on a device (and speaking for myself, also on a PC) you work with fit to content width and then you add just a little margin. But a custom zoom factor of 0.9 might be better depending on what you're trying to achieve.

@jonnyl2
Copy link

jonnyl2 commented May 17, 2024

fit to content width and then you add just a little margin

Yes, this works to gain back some of the removed margin, but if there wasn't any in the document to begin with, it won't add any extra margin.

@Frenzie
Copy link
Member

Frenzie commented May 17, 2024

Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants