-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VirtualKeyboard: delete word on backspace swipe west #11843
Conversation
Word delimiters, discussable: koreader/frontend/ui/widget/inputtext.lua Line 768 in 775e841
|
If I have the cursor in the middle of a word, ie |
On Android it's the last one, which seems more intuitive but perhaps also less useful? |
It deletes the full word (between delimiters) under the cursor. |
I also feel deleting just the part before the cursor is more intuitive, at least what I would expect.
You mean the cursor is at the immediate end of the previous word, and I need to input a space before typing my new word? |
Yes, I thought it was convenient. |
So would we rather only left of cursor or whole word? |
Added dashes as word delimiters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and see how it works.
Just to be clear, we now have FOUR backspaces?
Shouldn't it be easier if (1) stays, but 2-4 are put into a popup menu that opens with a long tap? |
I don't know, it's roughly the same as on most other mobile keyboards. :-) I don't think we've implemented ctrl+backspace on keyboard yet. |
Closes #11831.
This change is