Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion operators from/to View and mdspan #6805

Closed
nmm0 opened this issue Feb 12, 2024 · 0 comments · Fixed by #6830
Closed

Add conversion operators from/to View and mdspan #6805

nmm0 opened this issue Feb 12, 2024 · 0 comments · Fixed by #6830
Assignees
@nmm0
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
Developer: Nicolas Morales
Milestone
Release 4.3

Comments

@nmm0
Copy link
Contributor

nmm0 commented Feb 12, 2024

The general interface should follow the operations in mdarray.

Initially the converting constructor will just use std::default_accessor and create an unmanaged view. We will add space-aware accessors in a separate PR.
@nmm0 nmm0 added the Enhancement Improve existing capability; will potentially require voting label Feb 12, 2024
@nmm0 nmm0 added this to the Release 4.3 milestone Feb 12, 2024
@nmm0 nmm0 self-assigned this Feb 12, 2024
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 21, 2024
@nmm0
kokkos#6805: update mdspan
5b8a2ae
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 21, 2024
@nmm0
kokkos#6805: add initial converting constructor from mdspan to view
d3d4d84
@nmm0 nmm0 mentioned this issue Feb 21, 2024
Merged
2 tasks
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 21, 2024
@nmm0
kokkos#6805: some formatting fixes
0f2a05d
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 21, 2024
@nmm0
kokkos#6805: guard mdspan conversion test
a619453
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 21, 2024
@nmm0
kokkos#6805: some more formatting fixes
3b54534
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 22, 2024
@nmm0
kokkos#6805: update mdspan tpl to avoid shadowed variable warning
49162ef
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 23, 2024
@nmm0
kokkos#6805: fix host function call from device and fix more cuda war…
c5711c1 
…nings in mdspan
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 26, 2024
@nmm0
kokkos#6805: fix more formatting
52aaaeb
nmm0 added a commit to nmm0/kokkos that referenced this issue Feb 26, 2024
@nmm0
kokkos#6805: update mdspan to try to address intel compiler warnings
3dec933
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 1, 2024
@nmm0
kokkos#6805: fix constraints on mdspan converting constructor and all…
21b422b 
…ow runtime-unmanaged (but compile-time managed) views to be constructed from mdspans
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 1, 2024
@nmm0
kokkos#6805: make mdspan helpers namespace consistent
443db9d
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 1, 2024
@nmm0
kokkos#6805: add conversion to mdspan
5310110
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: add initial converting constructor from mdspan to view
83b12f7
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: some formatting fixes
d6bc2c8
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: guard mdspan conversion test
498ed72
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: fix host function call from device and fix more cuda war…
ef8e9c9 
…nings in mdspan
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: fix more formatting
27f9f24
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: fix constraints on mdspan converting constructor and all…
abf39d2 
…ow runtime-unmanaged (but compile-time managed) views to be constructed from mdspans
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: make mdspan helpers namespace consistent
9650d07
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: add conversion to mdspan
560db47
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: add to_mdspan
6fa3de9
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 6, 2024
@nmm0
kokkos#6805: fix formatting and update tests
7960ee0
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 7, 2024
@nmm0
kokkos#6805: add initial converting constructor from mdspan to view
854fbf0
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 7, 2024
@nmm0
kokkos#6805: some formatting fixes
741df00
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 7, 2024
@nmm0
kokkos#6805: guard mdspan conversion test
caf9242
nmm0 added a commit to nmm0/kokkos that referenced this issue Mar 7, 2024
@nmm0
kokkos#6805: fix host function call from device and fix more cuda war…
56ffeb6 
…nings in mdspan
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: remove stray character
df54132
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: address some initial PR comments
885c953
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix dependency on ExecutionSpace template parameter
9ac9c63
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: move MDSpan impl from Kokkos::Experimental::Impl->Kokkos…
dafaf2d 
…::Impl
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: move dimension_from_extent
fba7595
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix formatting
343fe8f
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix array overrun bug in stride conversion function
6dda5bc
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix unused parameter on 0 size views
2706406
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: disable clang formatting for usage of maybe_unused as it…
134419a 
… gives incorrect C++
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: address PR feedback in test
5730e4b
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix namespace in test
7459ea8
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: move test out of subdirectory
df61bc2
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: arrange test alphabetically
1d83ecb
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix test
8476cd5
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: use the extent value for constructing static extents in …
a67dde1 
…layouts rather than 0
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: remove dimension_from_extent as it is not used anymore
7f413d9
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix formatting
1b6ee01
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: switch out conditionally explicit macro for explicit che…
47d121d 
…ck on C++ version and a comment
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix constraints on implicit mdspan conversion and test f…
5f4b5fb 
…or undesirable implicit conversions
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: add test for reproducing padding issue
4d4e108
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: use strides for layout_left_padded and layout_right_padded
ca856a9
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix formatting
8479e8e
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: add mdspan fixes from kokkos/mdspan#327
be51f9d
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: make mdspan conversion compatible with device code
2792eeb
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix accidentally disabled code
7c74565
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: address PR feedback
75bb319
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: don't allow arbitrary padding values
ff819c8
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: fix formatting
673adfe
nmm0 added a commit to nmm0/kokkos that referenced this issue May 15, 2024
@nmm0
kokkos#6805: add maybe_unused to indices for checking padding on conv…
53efc51 
…ersion from mdspan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmm0 nmm0

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
Developer: Nicolas Morales
Awaiting triage
Milestone
Release 4.3
Development

Successfully merging a pull request may close this issue.

mdspan converting constructors nmm0/kokkos
1 participant
@nmm0