-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test NaN in Bsr SpMV #2187
Closed
Closed
Test NaN in Bsr SpMV #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Intent of these changes is to allow for building Trilinos with KokkosKernels as an external TPL
Creation of the 'lapack' subdirectory, parallel to 'blas'
…aliases KokkosKernelsConfig.cmake: add all_libs target and necessary aliases
Add sptrsv execution space overloads
hide native merge-path SpMV behind "native-merge"
Quick fix on 'lapack' subdirectory, for night compilation with Trilinos
Since SpTRSV does not implement the TPL layer the usual way we need to be extra careful before calling the TPL implementation path. If cusparse is not available then we definitely want to revert back to calling the native implementation. Similarly, if the execution space is not Kokkos::CUDA, let's use the native implementation.
Check that CUSPARSE is enabled and that HandleExecSpace is Kokkos::CUDA before allowing users to set the implementation to use the CUSPARSE TPL.
Since we are guarding the cusparse path a bit better we need to be careful when some types are defined and to mark some variables (void) when they do not get used by an implementation...
Sptrsv check cusparse
SYCL: fix for Trilinos build with MKL
* Progress * Attempt 1, fix multiplication order * Converges in 1 step * Various cleanups * Be sure not to reduce performance of unblocked impl Also add some comments. * Remove test mangling * Fixes for GPU * Fix warning * formatting * Increase eps for floats * This is no longer needed
Address issue kokkos#2175 Configuring with magma tpl enabled and cusparse disabled mistakenly triggers the cusparse tpl avail check to be true Guard the KOKKOSSPARSE_SPMV_MV_TPL_SPEC_AVAIL_CUSPARSE macros when CUSPARSE is enabled to prevent this
Add guard for cusparse spmv_mv_tpl_spec_avail
…x-divide-by-zero-in-trsv Add early return if numRows == 0 in trsv to avoid integer divide-by-zero error
* magma: fix linker errors for builds without cusolver * BatchedGemm test: workaround testing cublas+magma - temporary workaround to skip magma test when cublas enabled to avoid issues like kokkos#2177
Add AutoTester2 CI Configs (Sans Power9 & ROCM w/ TPLS)
At2 ROCM+TPL fixes, remove volta70 too
- test against most recent kokkos release rather than develop branch, as done with AT CI, to avoid compatibility breakages
workflows/osx.yml: test against most recent kokkos tag
… symbol (kokkos#2183) Stick to pattern of removing leading 'c' or 'z' in method name and relying on the template type Co-authored-by: malphil <malphil@sandia.gov>
- Get rid of SYCL_OVERRIDE setting - Add MKL_PROVIDES_BLAS_LAPACK cmake variable and define so that code knows whether to use int, or MKL_INT - Trilinos builds might link with OneAPI for GPU but standard BLAS/LAPACK on CPU
oops (master) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2166