Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test NaN in Bsr SpMV #2187

Closed
wants to merge 303 commits into from
Closed

Test NaN in Bsr SpMV #2187

wants to merge 303 commits into from

Conversation

cwpearson
Copy link
Contributor

Fixes 2166

eeprude and others added 30 commits October 24, 2023 22:49
* Intent of these changes is to allow for building Trilinos with
  KokkosKernels as an external TPL
Creation of the 'lapack' subdirectory, parallel to 'blas'
…aliases

KokkosKernelsConfig.cmake: add all_libs target and necessary aliases
hide native merge-path SpMV behind "native-merge"
Quick fix on 'lapack' subdirectory, for night compilation with Trilinos
Since SpTRSV does not implement the TPL layer the usual way we need
to be extra careful before calling the TPL implementation path. If
cusparse is not available then we definitely want to revert back to
calling the native implementation. Similarly, if the execution space
is not Kokkos::CUDA, let's use the native implementation.
Check that CUSPARSE is enabled and that HandleExecSpace is
Kokkos::CUDA before allowing users to set the implementation to use
the CUSPARSE TPL.
Since we are guarding the cusparse path a bit better we need to be
careful when some types are defined and to mark some variables
(void) when they do not get used by an implementation...
SYCL: fix for Trilinos build with MKL
e10harvey and others added 26 commits April 8, 2024 07:39
* Progress

* Attempt 1, fix multiplication order

* Converges in 1 step

* Various cleanups

* Be sure not to reduce performance of unblocked impl

Also add some comments.

* Remove test mangling

* Fixes for GPU

* Fix warning

* formatting

* Increase eps for floats

* This is no longer needed
Address issue kokkos#2175
Configuring with magma tpl enabled and cusparse disabled mistakenly triggers the cusparse tpl avail check to be true
Guard the KOKKOSSPARSE_SPMV_MV_TPL_SPEC_AVAIL_CUSPARSE macros when CUSPARSE is enabled to prevent this
Add guard for cusparse spmv_mv_tpl_spec_avail
…x-divide-by-zero-in-trsv

Add early return if numRows == 0 in trsv to avoid integer divide-by-zero error
* magma: fix linker errors for builds without cusolver

* BatchedGemm test: workaround testing cublas+magma

- temporary workaround to skip magma test when cublas enabled to avoid issues like kokkos#2177
Add AutoTester2 CI Configs (Sans Power9 & ROCM w/ TPLS)
- test against most recent kokkos release rather than develop branch, as
  done with AT CI, to avoid compatibility breakages
workflows/osx.yml: test against most recent kokkos tag
… symbol (kokkos#2183)

Stick to pattern of removing leading 'c' or 'z' in method name and relying on the template type

Co-authored-by: malphil <malphil@sandia.gov>
- Get rid of SYCL_OVERRIDE setting
- Add MKL_PROVIDES_BLAS_LAPACK cmake variable and define so that
  code knows whether to use int, or MKL_INT
  - Trilinos builds might link with OneAPI for GPU but standard
    BLAS/LAPACK on CPU
@cwpearson
Copy link
Contributor Author

oops (master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge path doesn't zero out NaNs when beta=0