Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test coverage gaps #2016

Open
e10harvey opened this issue Oct 24, 2023 · 0 comments
Open

Unit test coverage gaps #2016

e10harvey opened this issue Oct 24, 2023 · 0 comments
Labels

Comments

@e10harvey
Copy link
Contributor

While working on #1987 and #1982, it became clear that not all of the gemv code paths are tested via the gemv unit tests. Upon closer inspection of the gemv unit test, it appears that many of the blas unit tests rely on the strided_view_adapter which always tests our interfaces with LayoutRight views regardless of the provided ViewType. The following unit tests are affected by this:

blas/unit_test/Test_Blas1_abs.hpp
blas/unit_test/Test_Blas1_asum.hpp
blas/unit_test/Test_Blas1_axpby.hpp
blas/unit_test/Test_Blas1_axpby_unification.hpp
blas/unit_test/Test_Blas1_axpy.hpp
blas/unit_test/Test_Blas1_dot.hpp
blas/unit_test/Test_Blas1_iamax.hpp
blas/unit_test/Test_Blas1_mult.hpp
blas/unit_test/Test_Blas1_nrm1.hpp
blas/unit_test/Test_Blas1_nrm2.hpp
blas/unit_test/Test_Blas1_nrm2_squared.hpp
blas/unit_test/Test_Blas1_nrm2w.hpp
blas/unit_test/Test_Blas1_nrm2w_squared.hpp
blas/unit_test/Test_Blas1_nrminf.hpp
blas/unit_test/Test_Blas1_reciprocal.hpp
blas/unit_test/Test_Blas1_scal.hpp
blas/unit_test/Test_Blas1_sum.hpp
blas/unit_test/Test_Blas1_team_abs.hpp
blas/unit_test/Test_Blas1_team_axpby.hpp
blas/unit_test/Test_Blas1_team_axpy.hpp
blas/unit_test/Test_Blas1_team_dot.hpp
blas/unit_test/Test_Blas1_team_mult.hpp
blas/unit_test/Test_Blas1_team_nrm2.hpp
blas/unit_test/Test_Blas1_team_scal.hpp
blas/unit_test/Test_Blas1_team_update.hpp
blas/unit_test/Test_Blas1_update.hpp
blas/unit_test/Test_Blas2_gemv.hpp
blas/unit_test/Test_Blas2_ger.hpp
blas/unit_test/Test_Blas2_syr.hpp
blas/unit_test/Test_Blas2_syr2.hpp

To address this, strided_view_adapter could be updated to accept and use a LayoutType template argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant