Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject submissions with error if they cannot be written to MongoDB #840

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Reject submissions with error if they cannot be written to MongoDB #840

merged 1 commit into from
Aug 8, 2022

Conversation

bufke
Copy link
Contributor

@bufke bufke commented Aug 8, 2022

Fix #837 by raising exception instead of only logging errors when saving submission to MongoDB

@bufke bufke requested a review from jnm August 8, 2022 19:29
@bufke bufke changed the base branch from master to beta August 8, 2022 19:29
jnm
jnm approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🌤️ 🌈 🙌

@jnm jnm merged commit b70d9b8 into beta Aug 8, 2022
@jnm jnm deleted the 837-reject-submissionms-with-error-from-mongodb branch August 8, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reject submissions with error if they cannot be written to MongoDB
2 participants
@bufke @jnm