Ambiguous _location in MeetingGroup

[shamil-sadigov]

Hi, Kamil!

Here, when we create Meeting we specify the location. MeetingGroup in turn also has _location which is not used anywhere, so I wonder, what sense does it make to have _location in MeetingGroup considering that we don't use it and specify other location when creating Meeting? 🤔

modular-monolith-with-ddd/src/Modules/Meetings/Domain/MeetingGroups/MeetingGroup.cs

Lines 96 to 123 in 37de062

	public Meeting CreateMeeting(
	string title,
	MeetingTerm term,
	string description,
	MeetingLocation location,
	int? attendeesLimit,
	int guestsLimit,
	Term rsvpTerm,
	MoneyValue eventFee,
	List<MemberId> hostsMembersIds,
	MemberId creatorId)
	{
	this.CheckRule(new MeetingCanBeOrganizedOnlyByPayedGroupRule(_paymentDateTo));
	this.CheckRule(new MeetingHostMustBeAMeetingGroupMemberRule(creatorId, hostsMembersIds, _members));
	return Meeting.CreateNew(
	this.Id,
	title,
	term,
	description,
	location,
	MeetingLimits.Create(attendeesLimit, guestsLimit),
	rsvpTerm,
	eventFee,
	hostsMembersIds,
	creatorId);
	}

[kgrzybek]

Hi @shamil-sadigov

As far as I remember, in Meetup application, you have a location for a Meeting Group and for particular Meetings.

Location from Meeting Group is used in the Read Model: https://github.com/kgrzybek/modular-monolith-with-ddd/blob/548c1c28d597fa4b7f675f211cb045e5d9e0b067/src/Modules/Meetings/Application/MeetingGroups/GetAllMeetingGroups/MeetingGroupDto.cs

One note: According to DDD Aggregate definition you should not have attributes which are not used to protect business invariants. This is that case and location should be moved outside the aggregate. However, I am not such a orthodox and sometimes I keep more data in an aggregate if it does not affect performance and causes concurrency issues.