Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option for kedro new and kedro run to skip telemetry (e.g. for CI/CD environment) #2867

Closed
Tracked by #1640
noklam opened this issue Jul 31, 2023 · 10 comments · Fixed by #3701 or #3876
Closed
Tracked by #1640

Add an option for kedro new and kedro run to skip telemetry (e.g. for CI/CD environment) #2867

noklam opened this issue Jul 31, 2023 · 10 comments · Fixed by #3701 or #3876
Assignees
@iamelijahko @lrcouto
Milestone
Ensure packaged K...

Comments

@noklam
Copy link
Contributor

noklam commented Jul 31, 2023 •
edited by merelcht

Description

When you have created a Kedro project and execute a kedro command on the CLI for the first time it asks for consent to run kedro-telemetry. This is annoying when you create kedro projects as part of a CI/CD run.

The task is to add an option to kedro new e.g. --telemetry, --no-telemetry to allow the user to immediately register their consent choice for a Kedro project and skip the prompt for it later on.

Discuss with design what flag name would be most consistent with the other kedro new flags.

Context

Can I also ask for telemetry consent at this point as well? For CI/CD workflows this is critical.
Originally posted by @datajoely in #2865 (comment)

Implement logic in the kedro new command that detects if it's being run in CI and if so, whether consent has been given and if that's not the case then it will advice the user on how to do this.

i.e. kedro new --skip-ci
@noklam noklam closed this as completed Jul 31, 2023
@noklam noklam reopened this Jul 31, 2023
@noklam noklam mentioned this issue Jul 31, 2023
Open
3 tasks
@noklam noklam mentioned this issue Jul 31, 2023
Closed
@github-actions github-actions bot mentioned this issue Aug 18, 2023
Closed
@merelcht merelcht changed the title Add an option for kedro new to skip telemetry for CI/CD environment Add an option for kedro new to skip telemetry (e.g. for CI/CD environment) Aug 31, 2023
@datajoely
Copy link
Contributor

This should also have the option to consent too not just opt out

@astrojuanlu
Copy link
Member

Brainstorming

  • --consent-telemetry/--no-consent-telemetry
  • --accept-telemetry/--reject-telemetry
  • --opt-in-telemetry/--opt-out-telemetry
  • ❓

@datajoely
Copy link
Contributor

I would do kedro new --telemetry/-t {false,true,t,f,T,F} default True?

@astrojuanlu
Copy link
Member

Telemetry doesn't affect only CI/CD environments: also Jupyter-based ones (that don't have good support for interactive prompts) https://linen-slack.kedro.org/t/16098616/hi-i-m-running-a-kedro-project-on-databricks-and-when-i-load#6573391b-2b80-41ce-9265-e61041be9ff5

image

@astrojuanlu

This comment was marked as off-topic.

Sign in to view
@datajoely datajoely mentioned this issue Jan 31, 2024
Closed
@astrojuanlu
Copy link
Member

And this as a example of how we need to fix the consent workflow in non-interactive environments 😂
https://github.com/deepyaman/jaffle-shop/blob/48d47db7bfae4495f84cfafb1217923a7cf7b49b/.github/workflows/kedro-viz.yml#L26C8-L26C49

Originally posted by @datajoely in kedro-org/kedro-devrel#129 (comment)

@lrcouto lrcouto self-assigned this Mar 11, 2024
@lrcouto lrcouto linked a pull request Mar 13, 2024 that will close this issue
Add an option for kedro new to skip telemetry #3701
Merged
7 tasks
@astrojuanlu astrojuanlu mentioned this issue Mar 19, 2024
Merged
7 tasks
@astrojuanlu
Copy link
Member

When I saw this issue I jumped directly to brainstorming #2867 (comment) but even after identifying that this is not related to the kedro new command itself #2867 (comment) I didn't stop and think what part of the user journey we intended to fix.

Added more thoughts on #3701 (review)

@astrojuanlu
Copy link
Member

Partially addressed by #3701, let's add this flag to kedro run too as agreed on #3701 (comment)

@astrojuanlu astrojuanlu reopened this Apr 4, 2024
@astrojuanlu astrojuanlu changed the title Add an option for kedro new to skip telemetry (e.g. for CI/CD environment) Add an option for kedro new and kedro run to skip telemetry (e.g. for CI/CD environment) Apr 4, 2024
@lrcouto lrcouto linked a pull request May 17, 2024 that will close this issue
Add implementation of telemetry consent flag for kedro run #3876
Merged
7 tasks
@lrcouto lrcouto reopened this May 22, 2024
@lrcouto
Copy link
Contributor

lrcouto commented May 22, 2024

Reopening because kedro-org/kedro-plugins#681 still needs some reviewing.

@astrojuanlu astrojuanlu mentioned this issue May 23, 2024
Closed
4 tasks
@astrojuanlu
Copy link
Member

After discussing this a bit more internally, we decided to skip this idea. The way we'll solve the original user problem #1640 will be different, will leave some context there.

I'm closing this as "not planned".

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamelijahko iamelijahko

@lrcouto lrcouto

Labels
None yet
Projects
Kedro Framework
Status: Done
Milestone
Ensure packaged Kedro projects can ru...
5 participants
@astrojuanlu @noklam @datajoely @iamelijahko @lrcouto