Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor comments on improving the code #27

Open
mary-tsekhmistrenko opened this issue May 11, 2016 · 3 comments
Open

Some minor comments on improving the code #27

mary-tsekhmistrenko opened this issue May 11, 2016 · 3 comments

Comments

@mary-tsekhmistrenko
Copy link
Collaborator

mary-tsekhmistrenko commented May 11, 2016

  • write a function for merging two different datasets together. Eg, if you have a folder obspydmt_data_1 and an other folder obspydmt_data_2 with overlapping events, then you can make a folder obspydmt_complete folder and everything is in the right shape
  • for various plotting function it would be great if it would be possible to choose between networks (e.g. YV, II, etc) stations and events (eg. timespan, depth, magnitude). Eg for kml plots it's not possible to get specific networks
  • when I'm updating my database and do an instrument correction, then it corrects all stations again, which can be time consuming. Maybe include a flag and an external checker file for that, which only corrects what is new
  • test obspyDMT for one or none retrieved stations ( I have the feeling some functions don't take this too well)
  • last point: add a flag to update the event and station info according to the archived data
@john-robert
Copy link
Contributor

point 1 and 3 are very good suggestions. ;)

@mary-tsekhmistrenko
Copy link
Collaborator Author

points to code_refactoring:

  • get rid of '--min_date' flag or document this feature better, because it's not clear that when I'm using '--local' it does not process through my whole local folder
  • if I run obspyDMT on an external server the backend of matplotlib is not compatible with my local machine, with the result that it crashes when I want to produce plots (might not be for everybody the case) -->> this problem is solved by adding at the very top of obspyDMT.py:
    import matplotlib
    matplotlib.use('Agg')
  • after obspyDMT is finished it takes ages until it gets back to the prompt

@kasra-hosseini
Copy link
Owner

@mary-tsekhmistrenko suggested:

Another point for the naming of the continuous request, what about:

start record till end record
yyyy.jjj.ttttt_yyyy.jjj.ttttt
yyyy for year
jjj for julday
ttttt is for time in sec (max 86400 sec for one day)

and with that format you can easily differentiate between: flin.year.julday.letter because you don't have the underline in the name anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants